MK (fengmk2) comments

Results 691 comments of


                                            MK (fengmk2)

feat: support extra plugin dir by EGG_EXTRA_PLUGIN_DIR

@atian25 Take a look at this feature request?

fix: remove reckless assertion

add a socket assertion?

feat(loader): ignore .ts files in node_modules

@beary 加一下单元测试用例？

Update globby.

egg-core still need to support node 8, but globby@11 only support node >= 10 https://github.com/sindresorhus/globby/blob/v11.0.4/package.json#L14 We will merge this pull request on egg@3. cc @hyj1991

【请求addressList顺序】client 中的 addressList 优先级顺序问题

https://github.com/sofastack/sofa-rpc-node/blob/1921e7d96bac3f78bb3c6e52719856feb8cbc12f/lib/client/utils.js#L21 默认是打乱，是为了负载尽可能均衡。你可以 pull request 来实现你想要的能力。

U 更换 app.js 判断上下文 isSafeDomain 写法

这个逻辑错了，没有safedomian判断函数也应该直接通过。看来测试覆盖率不够

feat: use getByte() instead of get()

https://github.com/node-modules/byte/pull/27

feat: use getByte() instead of get()

deps on https://github.com/node-modules/byte/pull/29

[WIP] refactor: enhance decode performance

@gxcsoccer 比之前的 js 版本优化多少？加上对比

[WIP] refactor: enhance decode performance

ci 加上 node 7