egg-cors icon indicating copy to clipboard operation
egg-cors copied to clipboard

U 更换 app.js 判断上下文 isSafeDomain 写法

Open Onlylonger opened this issue 6 years ago • 2 comments

好像这种写法更易懂些

Onlylonger avatar Aug 02 '18 12:08 Onlylonger

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines           9      9           
=====================================
  Hits            9      9
Impacted Files Coverage Δ
app.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6ea4f2...4e20e27. Read the comment docs.

codecov[bot] avatar Aug 02 '18 12:08 codecov[bot]

这个逻辑错了,没有safedomian判断函数也应该直接通过。看来测试覆盖率不够

fengmk2 avatar Aug 02 '18 23:08 fengmk2