egg-core icon indicating copy to clipboard operation
egg-core copied to clipboard

Update globby.

Open superiums opened this issue 3 years ago • 2 comments

Checklist
  • [x] npm test passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines
Affected core subsystem(s)

update globby . affected fast-glob update. the old globby depends on fast-glob 2.x this will leads lots of egg module to request a such a directory must exist:

    egg-schedule/app/schedule
    egg-session/app/schedule
    egg-security/app/schedule
    ....
    egg-schedule/app/service
    egg-session/app/service
    egg-security/app/service
    ....
    egg-schedule/io/middleware
    egg-session/io/middleware
    egg-security/io/middleware
    ....

if the directory not exists, it throws an exception. so we sould update the fast-glob.

Description of change

update globby

not use globby 12.x because it support ES module only.

superiums avatar Dec 19 '21 03:12 superiums

egg-core still need to support node 8, but globby@11 only support node >= 10 https://github.com/sindresorhus/globby/blob/v11.0.4/package.json#L14

We will merge this pull request on egg@3. cc @hyj1991

fengmk2 avatar Jan 07 '22 15:01 fengmk2

Codecov Report

Base: 99.76% // Head: 99.76% // No change to project coverage :thumbsup:

Coverage data is based on head (687a6cb) compared to base (540f3fe). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2935     2935           
  Branches      546      546           
=======================================
  Hits         2928     2928           
  Misses          7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 07 '22 15:01 codecov[bot]

I will merge soon, we will release a major version egg-core and drop Node.js < 14 support

fengmk2 avatar Dec 19 '22 05:12 fengmk2

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jan 01 '23 15:01 github-actions[bot]