felixpalmer

Results 127 comments of felixpalmer

Why can't you do something like `getColor: d => [d.intensity, d.intensity, d.intensity]`?

I came across these as well, but hesitate to change them if they are not working. They are old examples, which as you say were written against an old version...

> I'm a bit concerned about having chunks of dead code I agree, v5 & 6 are very old. How about you remove the broken examples from this PR and...

> Now the access_token is required into new source functions, so the access_token need to add as dependency in `useMemo`, I would like to see how the workflow is affected...

@aaranadev we've come up with a pattern which avoids the need for using `useMemo`: https://github.com/visgl/deck.gl/pull/8214

> moving forward and backwards with the up/down arrow keys instead of up/down motion Yes, this is better - I've changed the jsfiddle to use this behavior. I originally had...

I can see that this will work well in the `TileLayer` zoom case as the first requests to be issued will become useless as the user zooms further and thus...

Yes that would be nice. I will try and follow the instancing example to get it working in deck

@chrisgervang @ibgreen I've added a task to the list above to include IBL. I have it as lower priority as my primary objective is getting something rendering in deck so...

Happy to see the number of #ifdefs dropping in the shaders as a result