deck.gl
deck.gl copied to clipboard
CARTO v9 API tracker
Tracker for work needed to land the new API for interacting with the CARTO backend.
Tasks
- [x] RFC https://github.com/visgl/deck.gl/pull/8051
- [x] Initial implementation https://github.com/visgl/deck.gl/pull/8130 against 8.9
- [ ] Test & review internally
- [x] Fix binary data (to make vector layers work) https://github.com/visgl/deck.gl/pull/8153
- [x] Initial implementaion against
masterhttps://github.com/visgl/deck.gl/pull/8167 - [x] Update website example https://github.com/visgl/deck.gl/pull/8191
- [x] Update playground example https://github.com/visgl/deck.gl/pull/8192
- [ ] Update pydeck
- [x] Remove CartoLayer https://github.com/visgl/deck.gl/pull/8217
- [x] Cleanup maps-v3-api https://github.com/visgl/deck.gl/pull/8224
- [x]
fetchMapsupport https://github.com/visgl/deck.gl/pull/8224 - [ ] Error checking to catch runtime errors (for JS users who won't get TS hints)
- [ ] Documentation https://github.com/visgl/deck.gl/pull/8228
- [ ] Fix tests
About the RFC #8051, I have a doubt about React considerations.
Now the access_token is required into new source functions, so the access_token need to add as dependency in useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.
For instance:
- the access_token expires
- the access_token is changed by the user
As far as I know, Maps API instantiation needs to be renewed.
cc: @menusal @VictorVelarde
Now the access_token is required into new source functions, so the access_token need to add as dependency in
useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.
In the case of a changing access token, it would be included in the useMemo dependency Array, which as you say will then trigger a new instantiation
Now the access_token is required into new source functions, so the access_token need to add as dependency in
useMemo, I would like to see how the workflow is affected if access_token changes or if you add it to the dependency array.In the case of a changing access token, it would be included in the
useMemodependency Array, which as you say will then trigger a new instantiation
Yes, perfect. I would like to test it when possible. Thx!
@aaranadev we've come up with a pattern which avoids the need for using useMemo: https://github.com/visgl/deck.gl/pull/8214
@aaranadev we've come up with a pattern which avoids the need for using
useMemo: #8214
Oh great! I see the REQUEST_CACHE map being replaced