Andrey Fedorov
Andrey Fedorov
@sedghi now that we updated to 3.11.1, I tested it, and it is not working reliably. Sometime it shows the label (e.g., for this StudyInstanceUID `1.2.840.113654.2.55.10251457513072085864761297205518907029` in IDC), on some...
Works here: https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.2.840.113654.2.55.192012426995727721871016249335309434385&SeriesInstanceUIDs=1.2.840.113654.2.55.305538394446738410906709753576946604022,1.2.276.0.7230010.3.1.3.313263360.15787.1706310178.804490 Doesn't work here: https://viewer.imaging.datacommons.cancer.gov/v3/viewer/?StudyInstanceUIDs=1.3.6.1.4.1.32722.99.99.173744694849724904145228624619597754035 (segmentation series "Segmentation"). I think the issue here might be that it does not contain recommended color in DICOM. But it should not...
In addition, after testing this feature, I would like to mention it again that I do not think the current choice of using the same color for the text annotation...
Also, I think it is a bug that the annotation does not disappear if I scroll and the cursor is no longer at the same label as it was at...
@sedghi - @igoroctaviano is saying that automatic load of SEG was working in v3 at some point. Would it be possible to add a test to make sure this regression...
As discussed with @igoroctaviano, let's have it merged, and we can consider switching to using hanging protocol option when it is available.
Specifically, while converting a Hamamatsu sample from https://openslide.cs.cmu.edu/download/openslide-testdata/Hamamatsu/, `bfconvert` populates `PixelSpacing` as follows, which exceeds the limit of 16 characters for the `DS` DICOM VR. ``` (0028,0030) DS [4.564125969876768E-4\4.550625711035267E-4] #...
> ``` > ... > > (0x0028,0x0030) DS Pixel Spacing VR= VL= > ... > ``` Why not use scientific notation?
Here's somewhat related issue, just for the reference - we went quite a bit back and forth on how to ensure best use of the limited character length: https://github.com/QIICR/dcmqi/issues/414 (that...
Here's that function in a GitHub repo where I synchronize @dclunie pixelmed, for convenience: https://github.com/fedorov/pixelmed/blob/f9b7844749f15fd8d6523d119f4c3792738c40a3/com/pixelmed/utils/FloatFormatter.java#L105-L227