Federico Jeanne

Results 138 comments of Federico Jeanne

@ShahzaibIbrahim please also improve the commit message: * Remove the links from the first line (they are in the body anyway) * Add the text "Fixes" or "Contributes to" appropriately...

@ShahzaibIbrahim thank you for adding a _How to test_. I tested in **Windows 10** and I see no difference before and after this PR. ## Before (Table, size 100x100) Zoom...

I tested it again and I still see no difference between before and after this PR. Moreover, the status **before** this PR looks OK (I see both scroll bars when...

You could just copy it there since the issue is new and no discussion really happened :)

> I believe it is not a good idea. We had discussions in the past. Mixing old/new code styles wouldn't be helpful. How about running the formatter once for every...

What kind of problems could be caused by reformatting the code? You mean like actually breaking it (failed tests/new bugs)?

@iloveeclipse I made some changes and adapted the commit text, the description of this PR and its title. Only the tests and examples have the preferences (all projects). Would you...

> 1. Why should we enable auto-formatting for projects that do not have formatter setting specified? If I see correctly, the SWT proejcts don't have any project-specific formatter settings. This...

> > Good point. I suggest using the "Eclipse [built-in]" profile. Agreed @HeikoKlare / @HannesWell ? > > That's the one we use in the Platform repos, so yes, that's...

> My comment was based on the assumption that this affects clean-up operations rather than save actions. Still, the PR is not limited to enabling auto-formatting edited code. It also...