Federico Jeanne
Federico Jeanne
@iloveeclipse have I addressed your comments?
> Where are the new `org.eclipse.jdt.core.prefs` formatter settings coming from? I haven't reviewed every file, I assume they are all copy/pasted from some single source. They were automatically created when...
> Since this PR adds many new lines of preferences, have you considered to link the jdt preference files from a common location e.g. from the `examples` or `tests` folder?...
Thank you for the hint @HeikoKlare , I was doing it wrong (I was creating links from the Windows Explorer), that's why it didn't work. I replaced the newly created...
> Please see #1253. @HannesWell thank you! I just reviewed it, it looks very good :-) . I will then leave this PR on hold (as a draft) until #1253...
> There are a number of conflicts here. Do you plan to finish this one or it should be abandoned? I'll take a look at it next week (I'm in...
@jukzi good to know that the workaround actually works, thank you! (Pity that the reporter of #1185 never answered https://github.com/eclipse-platform/eclipse.platform.swt/issues/1185#issuecomment-2106875497)
> > @BeckerWdf thank you for the fix for Mac. > > I haven't looked at the code but I see that this PR doesn't really fix #1233 but only...
> I just wanted to note that (platform dependent) _package private_ or even _public_ fields / methods are quite common, they should just be documented in this case as platform...
@deepika-u thank you for the analysis. I made a quick analysis myself and reached the same conclusion: if the expected default behavior is changed then the client code needs to...