Fionn Malone

Results 56 comments of Fionn Malone

From #651 we need updates for: 1. QFxp 2. BoundedQInt 3. QIntOnesComplement

No, I need to profile to see why Fxp is so slow.

![Screenshot 2023-10-31 at 2 30 44 PM](https://github.com/quantumlib/Qualtran/assets/12097876/2e75a945-5c1a-4c51-9225-4fad42db45a9)

@mpharrigan / @tanujkhattar what are your thoughts on adding a ControlledHadamard Bloq, which possibly delays the above implementation and just tags the cost? It would be nice to have this...

![Screenshot 2023-09-22 at 12 32 56 PM](https://github.com/quantumlib/Qualtran/assets/12097876/8989e9eb-4907-44a5-97b7-e82384d92865)

Modifying the bloq directly with the generalizer is definitely not the way to go.

A maybe better way to do it is ``` python from qualtran.bloqs.and_bloq import And and_cv0 = ssa.new_symbol('cv0') and_cv1 = ssa.new_symbol('cv1') def generalize(bloq): if ('cirq.And' in bloq.pretty_name()) and (len(bloq.gate.cv) == 2):...

@mpharrigan is this last way something sensible, or is there a better way?

Could you just add a CX gate controlled on the target of the original inequality target?