Fred Bricon

Results 583 comments of Fred Bricon

> If ConfigPhase == RUN_TIME, we should not validate the default value? We can start with that. Maybe @ia3andy or @gsmet can confirm whether we need to validate references from...

mmm that sucks. Seems like this works with vscode insiders but not the last official release. @snjeza can you double check that please?

Looks like the same issue exists in typescript in the last vscode release. Works with insiders (I'm using the same patterns). So I'd say, we ship it anyway. It'll be...

@snjeza FYI I opened https://github.com/Microsoft/vscode/issues/62198 upstream

@snjeza I'm taking another shot at this old issue, it seems to work now. Please review.

@snjeza let me know if you can't review this PR, I'll ask someone else

damn, works for me ![move-lines](https://github.com/user-attachments/assets/2ada4c23-91df-463e-843d-c089008e908b)

wait your gif shows the problem is fixed on Java (yeah!), not typescript (we don't care). On the same vscode version, it also works for me on typescript.

OK so if the line under the if is not indented, moving line 2 up de-increments it, which is not happening with this PR. So we'd be swapping the bug...

You have one file missing from https://github.com/eclipse/lemminx/tree/main/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/participants/codeactions/missingelement. Try `git reset --hard origin main`