Mark Farnum

Results 11 comments of Mark Farnum

Can confirm that building also fails on MacOS, even after trying multiple version of Lemons. My environment: ``` MacOS Catalina v10.15.7 cmake version 3.22.3 Doxygen version 1.9.3 ``` I modified...

This is because the defaults settings are only returned when you call a method on the `SettingObject`. So, this will just return a SettingObject that indicates that nothing has been...

I experienced this issue an hour ago but am now unable to reproduce, so it may be fixed.

Can confirm this branch removes the warnings when I tested.

+1 to using Rosetta in Docker Desktop — this unblocked me

> Possible duplicate of #1074 Did you mean to reference a different issue? That's this issue.

@tklebanoff are you using [f.lux](https://justgetflux.com/) or some other service that adjusts your display? I had the same exact issue but was able to resolve it by disabling f.lux. When running...

@tklebanoff for the moment I've switched to using the Mac OS built-in Night Mode setting and manually adjusting, but I would prefer not to do that. Lumen uses the [`IODisplayGetFloatParameter`](https://github.com/anishathalye/lumen/blob/b5825d06ec72259c465452366fde4242f3cca14a/Lumen/BrightnessController.m#L206)...

@twelch just checked and the behavior on `7.0.0` is the same (the `mask` input is mutated). I've opened a PR to fix here: #2635

I just updated the benchmark code in that PR as well. Interestingly, there doesn't seem to be much of a performance difference, just a small perf boost when `mutate =...