react-native-snap-carousel
react-native-snap-carousel copied to clipboard
Use deprecate-react-native-prop-types
Platforms affected
All
What does this PR do?
RN 0.68 has deprecated and will eventually remove ViewPropTypes
(see post). This adds the deprecated-react-native-prop-types
package and uses that instead.
What testing has been done on this change?
Local testing, to ensure the deprecation warning has been removed.
Tested features checklist
- [ ] Default setup (example)
- [ ] Carousels with and without momentum enabled (prop
enableMomentum
) - [ ] Vertical carousels (prop
vertical
) - [ ] Slide alignment (prop
activeSlideAlignment
) - [ ] Autoplay (prop
autoplay
) - [ ] Loop mode (prop
loop
) - [ ]
ScrollView
/FlatList
carousels (propuseScrollView
) - [ ] Callback methods
- [ ]
ParallaxImage
component - [ ]
Pagination
component - [ ] Layouts and custom interpolations
+1
Can confirm this branch removes the warnings when I tested.
Last August a similar PR was opened removing React proptypes. I believe this library is no longer being maintained, and has not received any update in over a year. I hope really popular react-native libraries are instead moved over to @react-community to maintain instead.
any chance to get merged?
I think this repo is dead
@bd-arc could you please take a look at this some minutes? We kind of have a problem here... This change is important. All the Expo users can't migrate to the new Expo SDK version because of this and some other small issues.
Please, consider taking a look at some PRs, or giving some Admin permissions to some trusted users.
Thanks!