react-native-snap-carousel icon indicating copy to clipboard operation
react-native-snap-carousel copied to clipboard

Use deprecate-react-native-prop-types

Open apfritts opened this issue 2 years ago • 6 comments

Platforms affected

All

What does this PR do?

RN 0.68 has deprecated and will eventually remove ViewPropTypes (see post). This adds the deprecated-react-native-prop-types package and uses that instead.

What testing has been done on this change?

Local testing, to ensure the deprecation warning has been removed.

Tested features checklist

apfritts avatar Apr 08 '22 18:04 apfritts

+1

cameronnapoli avatar May 11 '22 00:05 cameronnapoli

Can confirm this branch removes the warnings when I tested.

farkmarnum avatar May 12 '22 12:05 farkmarnum

Last August a similar PR was opened removing React proptypes. I believe this library is no longer being maintained, and has not received any update in over a year. I hope really popular react-native libraries are instead moved over to @react-community to maintain instead.

losh11 avatar May 25 '22 02:05 losh11

any chance to get merged?

mihneasuper avatar Jun 15 '22 10:06 mihneasuper

I think this repo is dead

easton36 avatar Jun 15 '22 17:06 easton36

@bd-arc could you please take a look at this some minutes? We kind of have a problem here... This change is important. All the Expo users can't migrate to the new Expo SDK version because of this and some other small issues.

Please, consider taking a look at some PRs, or giving some Admin permissions to some trusted users.

Thanks!

BrodaNoel avatar Jun 20 '22 03:06 BrodaNoel