Facu Spagnuolo

Results 14 comments of Facu Spagnuolo

@izqui I already addressed your comments, feel free to take another look :) I'll publish all the off-chain service stuff on a separate PR PS: The CI coverage task is...

Hey @luisivan! thanks a lot for your feedback! 😄 Regarding the `Registry` contract, it would be simple to have some similar contract to the `ENSRegistry` that acts as a registry...

Here are my two cents on that, we could add an optional argument to the current `assertRevert` expecting it to assert a revert with a custom message when given and...

Yea, that definitely will work, but I'm not sure if we won't break other repos. If we are sure we won't, it should be easy