dao-templates
dao-templates copied to clipboard
aragon
Improve geth dependency
Current templates are tested with a geth node, mainly used by the CI, using an Aragon's geth-devnet docker image. Tests are run relying on a previous step that basically waits until the gas limit of the node has increased to 8M gas. To avoid waiting time for that, we are committing the ethereum-data dir within the shared sub-repo. This dir will hold all the information related to the geth instance being run, thus files will be changing and git will keep tracking them.
We should improve this flow, either updating our geth image or exploring a painless way to deal with ethereum-data
Given that all networks are pretty much operating at 8M gas, can we not start geth in the docker image with that much gas?
Yea, that definitely will work, but I'm not sure if we won't break other repos. If we are sure we won't, it should be easy
Given that all networks are pretty much operating at 8M gas, can we not start geth in the docker image with that much gas?
I tried long time ago and it didn't work for me, maybe I was doing something wrong. I don't think it will break anything, so let's give it another try.
