react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Change Wrapper of InspectorPanel from View to SafeAreaView

Open raykle opened this issue 1 year ago • 2 comments

Summary

Currently, the InspectorPanel component is wrapped in View, which is a little difficult to click the panel button when in a device with a notch screen.

Changelog

[General] [Fixed] - Change Wrapper of InspectorPanel from View to SafeAreaView

Test Plan

From:

To:

raykle avatar Aug 25 '22 18:08 raykle

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,634,491 +0
android hermes armeabi-v7a 7,046,426 +0
android hermes x86 7,936,295 +0
android hermes x86_64 7,908,180 +0
android jsc arm64-v8a 9,511,917 +0
android jsc armeabi-v7a 8,287,198 +0
android jsc x86 9,451,448 +0
android jsc x86_64 10,042,696 +0

Base commit: 361b310bcc8dddbff42cf63495649291c894d661 Branch: main

analysis-bot avatar Aug 25 '22 18:08 analysis-bot

Hi @raykle, could you please rebase your PR?

cipolleschi avatar Aug 26 '22 13:08 cipolleschi

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 81564c1a3dae4222858de2a9a34089097f665e82 Branch: main

analysis-bot avatar Aug 29 '22 03:08 analysis-bot

Hi @lunaleaps, I have rebase the PR.

raykle avatar Aug 30 '22 02:08 raykle

Hi @lunaleaps , Sorry about that, I'm a little not familiar with the GitHub Pull Request flow, and I clicked the resolve conversation by mistake.

I agree with your suggestion absolutely! What should I do now? Change the code and push again?

raykle avatar Aug 31 '22 02:08 raykle

modified the code and also rebased it.

raykle avatar Aug 31 '22 02:08 raykle

Great, thank you!

lunaleaps avatar Aug 31 '22 16:08 lunaleaps

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 31 '22 16:08 facebook-github-bot

This pull request was successfully merged by @raykle in afad68f1a83995eaa42a8f1c7c636ccef8914797.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Aug 31 '22 18:08 react-native-bot