react-native
react-native copied to clipboard
feat: adding aria-label alias for accessibilityLabel
Summary
- Adding aria-label alias for accessibilityLabel
https://github.com/facebook/react-native/issues/34424
Changelog
[General] [Added] - Add aria-label
prop to Button
component
Test Plan
<Button
onPress={() => onButtonPress('cancelled')}
testID="cancel_button"
color={theme.SystemRedColor}
title="Cancel Application"
aria-lable="Press to cancel your application!"
/>
Hi @necolas, I Just Wanted to know if this is the right way. I will add other components if it's good to go. Open to suggestions.
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 7,641,940 | +498 |
android | hermes | armeabi-v7a | 7,054,235 | +501 |
android | hermes | x86 | 7,943,663 | +498 |
android | hermes | x86_64 | 7,915,717 | +492 |
android | jsc | arm64-v8a | 9,515,205 | +483 |
android | jsc | armeabi-v7a | 8,290,815 | +484 |
android | jsc | x86 | 9,454,534 | +483 |
android | jsc | x86_64 | 10,045,602 | +483 |
Base commit: 5e1c4d4203738452d0869d45b7b4fead5c16db00 Branch: main
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
ios | - | universal | n/a | -- |
Base commit: 5e1c4d4203738452d0869d45b7b4fead5c16db00 Branch: main
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Hi @Viraj-10, could you rebase your branch, please?
Hi @Viraj-10, could you rebase your branch, please?
@cipolleschi, okay
@Viraj-10 I have to ask if you can rebase this PR again... Also thanks for applying the suggestions!
@Viraj-10 I have to ask if you can rebase this PR again... Also thanks for applying the suggestions!
Sure, No worries.
There are some errors in CI, could you have a look at them, please?
Hi @Viraj-10, there are still errors. You can see them here: https://app.circleci.com/pipelines/github/facebook/react-native/15336/workflows/555b206f-388d-4dbd-868e-4727297563be/jobs/283063
An example of those is:
/home/circleci/react-native/Libraries/Components/Pressable/Pressable.js
226:5 error Duplicate key 'accessibilityLabel' no-dupe-keys
227:5 error Duplicate key 'accessibilityState' no-dupe-keys
could you have a look at them?
Hi @cipolleschi @necolas, Sorry for the delay. I guess I have added an alias in all the components possible. Please review Once and let me know.
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Hi @cipolleschi, All test cases are passed and I have resolved all the merge conflicts.
This pull request was successfully merged by @Viraj-10 in 720cdbc658aa0b513d106526eb81d749fa957c99.
When will my fix make it into a release? | Upcoming Releases