react-native icon indicating copy to clipboard operation
react-native copied to clipboard

feat: adding aria-label alias for accessibilityLabel

Open Viraj-10 opened this issue 1 year ago • 4 comments

Summary

https://github.com/facebook/react-native/issues/34424

Changelog

[General] [Added] - Add aria-label prop to Button component

Test Plan

<Button
     onPress={() => onButtonPress('cancelled')}
     testID="cancel_button"
     color={theme.SystemRedColor}
     title="Cancel Application"
     aria-lable="Press to cancel your application!"
/>

Viraj-10 avatar Aug 26 '22 04:08 Viraj-10

Hi @necolas, I Just Wanted to know if this is the right way. I will add other components if it's good to go. Open to suggestions.

Viraj-10 avatar Aug 26 '22 04:08 Viraj-10

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,641,940 +498
android hermes armeabi-v7a 7,054,235 +501
android hermes x86 7,943,663 +498
android hermes x86_64 7,915,717 +492
android jsc arm64-v8a 9,515,205 +483
android jsc armeabi-v7a 8,290,815 +484
android jsc x86 9,454,534 +483
android jsc x86_64 10,045,602 +483

Base commit: 5e1c4d4203738452d0869d45b7b4fead5c16db00 Branch: main

analysis-bot avatar Aug 26 '22 04:08 analysis-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5e1c4d4203738452d0869d45b7b4fead5c16db00 Branch: main

analysis-bot avatar Aug 26 '22 05:08 analysis-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 26 '22 13:08 facebook-github-bot

Hi @Viraj-10, could you rebase your branch, please?

cipolleschi avatar Aug 30 '22 09:08 cipolleschi

Hi @Viraj-10, could you rebase your branch, please?

@cipolleschi, okay

Viraj-10 avatar Aug 30 '22 10:08 Viraj-10

@Viraj-10 I have to ask if you can rebase this PR again... Also thanks for applying the suggestions!

cipolleschi avatar Aug 30 '22 16:08 cipolleschi

@Viraj-10 I have to ask if you can rebase this PR again... Also thanks for applying the suggestions!

Sure, No worries.

Viraj-10 avatar Aug 31 '22 07:08 Viraj-10

There are some errors in CI, could you have a look at them, please?

cipolleschi avatar Aug 31 '22 13:08 cipolleschi

Hi @Viraj-10, there are still errors. You can see them here: https://app.circleci.com/pipelines/github/facebook/react-native/15336/workflows/555b206f-388d-4dbd-868e-4727297563be/jobs/283063

An example of those is:

/home/circleci/react-native/Libraries/Components/Pressable/Pressable.js
  226:5  error  Duplicate key 'accessibilityLabel'  no-dupe-keys
  227:5  error  Duplicate key 'accessibilityState'  no-dupe-keys

could you have a look at them?

cipolleschi avatar Sep 05 '22 09:09 cipolleschi

Hi @cipolleschi @necolas, Sorry for the delay. I guess I have added an alias in all the components possible. Please review Once and let me know.

Viraj-10 avatar Sep 05 '22 20:09 Viraj-10

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 07 '22 12:09 facebook-github-bot

Hi @cipolleschi, All test cases are passed and I have resolved all the merge conflicts.

Viraj-10 avatar Sep 09 '22 08:09 Viraj-10

This pull request was successfully merged by @Viraj-10 in 720cdbc658aa0b513d106526eb81d749fa957c99.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Sep 09 '22 18:09 react-native-bot