react-native icon indicating copy to clipboard operation
react-native copied to clipboard

feat: added aria-modal as alias for accessibilityViewIsModal(iOS)

Open dakshbhardwaj opened this issue 1 year ago • 7 comments

Summary

This adds the aria-modal prop to the components where it's used as requested on https://github.com/facebook/react-native/issues/34424, mapping web aria-modal to equivalent accessibilityViewIsModal

Changelog

[General] [Added] - Add aria-modal prop to basic component

TestPlan

Checked manually we are receiving the values by props.

dakshbhardwaj avatar Aug 26 '22 08:08 dakshbhardwaj

Warnings
:warning: :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by :no_entry_sign: dangerJS against ad116e0a26e78f2e27147d20e150db15587c6fc8

github-actions[bot] avatar Aug 26 '22 08:08 github-actions[bot]

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,641,629 +467
android hermes armeabi-v7a 7,053,984 +461
android hermes x86 7,943,406 +475
android hermes x86_64 7,915,311 +462
android jsc arm64-v8a 9,514,777 +390
android jsc armeabi-v7a 8,290,381 +382
android jsc x86 9,454,094 +379
android jsc x86_64 10,045,174 +390

Base commit: 82e9c6ad611f1fb816de056ff031716f8cb24b4e Branch: main

analysis-bot avatar Aug 26 '22 08:08 analysis-bot

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

cipolleschi avatar Aug 26 '22 13:08 cipolleschi

Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main?

@cipolleschi I have rebased it with main

dakshbhardwaj avatar Aug 26 '22 13:08 dakshbhardwaj

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e8739e962de3398bc7e42675b1d87ab35993f705 Branch: main

analysis-bot avatar Aug 26 '22 13:08 analysis-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 26 '22 16:08 facebook-github-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 26 '22 18:08 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 05 '22 09:09 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 07 '22 12:09 facebook-github-bot

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 08 '22 08:09 facebook-github-bot

@jacdebug i have pushed the changes

dakshbhardwaj avatar Sep 09 '22 12:09 dakshbhardwaj

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Sep 12 '22 07:09 facebook-github-bot

This pull request was successfully merged by @dakshbhardwaj in 095f19a681e22bd5f9438758112cc9628499b631.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Sep 12 '22 12:09 react-native-bot