react-native
react-native copied to clipboard
feat: added aria-modal as alias for accessibilityViewIsModal(iOS)
Summary
This adds the aria-modal
prop to the components where it's used as requested on https://github.com/facebook/react-native/issues/34424, mapping web aria-modal to equivalent accessibilityViewIsModal
Changelog
[General] [Added] - Add aria-modal prop to basic component
TestPlan
Checked manually we are receiving the values by props.
Warnings | |
---|---|
:warning: | :clipboard: Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
Generated by :no_entry_sign: dangerJS against ad116e0a26e78f2e27147d20e150db15587c6fc8
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 7,641,629 | +467 |
android | hermes | armeabi-v7a | 7,053,984 | +461 |
android | hermes | x86 | 7,943,406 | +475 |
android | hermes | x86_64 | 7,915,311 | +462 |
android | jsc | arm64-v8a | 9,514,777 | +390 |
android | jsc | armeabi-v7a | 8,290,381 | +382 |
android | jsc | x86 | 9,454,094 | +379 |
android | jsc | x86_64 | 10,045,174 | +390 |
Base commit: 82e9c6ad611f1fb816de056ff031716f8cb24b4e Branch: main
Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on main
?
Hi @dakshbhardwaj, thanks for your PR. Could you please rebse this on
main
?
@cipolleschi I have rebased it with main
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
ios | - | universal | n/a | -- |
Base commit: e8739e962de3398bc7e42675b1d87ab35993f705 Branch: main
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jacdebug i have pushed the changes
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This pull request was successfully merged by @dakshbhardwaj in 095f19a681e22bd5f9438758112cc9628499b631.
When will my fix make it into a release? | Upcoming Releases