Fabien Potencier
Fabien Potencier
I think that this node visitor must also enforce the availability of the variable at runtime to make this works correctly. Like converting the `types` tag to checks that would...
> Did you mean @drjayvee instead? Oops, sorry for the wrong ping.
Maybe it would be good to also deprecate the `include` tag in 3.15. My only "concern" is about the `embed` tag that is kind of a glorified include node behind...
That makes a lot of sense to me. Have you change them all?
Thank you @smnandre.
Sounds good to me.
Thank you @alexandre-daubois.
Let's calm down :) We are all trying to do our best trying to understands problems and finding the best appropriate solutions. Thank to @pounard for the great explanations and...
Some quick comments (I still haven't had time to work on this a lot): * We cannot take a decision by saying "this does not happen when using Twig with...
Reading the code, I'm wondering if we cannot "just" remove the `realpath` call in the constructor. As we are calling `realpath` on the full template filename later on, it seems...