Fabien Potencier comments

Results 517 comments of


                                            Fabien Potencier

[Validator] [UniqueValidator] Use correct variable as parameter in (custom) error message.

Thank you @seho-nl.

Memory Leak in Symfony Mailer when sending many attachments of >5MB

While trying to understand why I wrote the code, I realized we should never change the internal representation. So, #51872 looks like a slightly better fix.

Memory Leak in Symfony Mailer when sending many attachments of >5MB

@asmafarhat2006 That's correct. Fixing the bug means a change in behavior and as such, it cannot be part of 5.4. In any case, performance optimizations (CPU and memory) are not...

[HttpFoundation] Recursively order query string keys in `Request::normalizeQueryString()`

Closing as there is no more activity and the current patch cannot be merged as is. Feel free to reopen if that still makes sense.

EscaperRuntime::setSafeClasses() implementation

Can you tell us more about what does not work? I've just tried and it works well. I realize that `setSafeClasses()` might be a confusing method name. This is **only**...

Scheduler file in wrong directory

I tend to agree with @kbond

Support for multipart/form-data in non-POST requests using request_parse_body() (PHP 8.4)

@rottifant Please go ahead and submit a PR. That would ease reviews.

[Validator] Add option to allow ANY protocol in Assert\Url constraint

Thank you @Drkilla.

[FrameworkBundle] Add flag to sort `debug:router` output

@HMRDevil Are you still interested in finishing this PR? Ask for help if needed.

[FrameworkBundle] Add flag to sort `debug:router` output

Closing as there is no more activity and some unadressed comments. Feel free to reopen when you have time.