Fabien Potencier

Results 517 comments of Fabien Potencier

If we were to rename to function, `html_attr_join` sounds good to me.

@kbond If you're ok with the new name, can you update this PR?

Can you give a Twig template that exhibits the issue? This PR does not work as you can see in the tests.

The example you gave me emits a warning, which is not cause by Twig. The error message given by PHP gives you the file and line number where it happens,...

@SiebelsTim Would you like to work on a PR on the 3.x branch to improve the current situation?

Any news @HeahDude?

@stof It would be great if you could submit a PR. Having it in CoreExtension sounds good to me.

I've tried several times to fix it but it's really complicated as we don't have enough context when we need it.

@kitsguru It will be fixed eventually, but any help would be more than welcome.

Closing as there is no more feedback.