Fabien Potencier comments

Results 517 comments of


                                            Fabien Potencier

incomplete result of debug:validator command

@macintoshplus Do you want to investigate and work on a fix?

[DependencyInjection] Exclude referencing service (self) in `TaggedIteratorArgument`

Thank you @chalasr.

[Mailer] add reject to `MessageEvent` to stop sending mail

@VincentLanglet Feel free to take over if you have time to finish this PR.

[Mailer] add reject to `MessageEvent` to stop sending mail

> > @VincentLanglet Feel free to take over if you have time to finish this PR. > > Hi @fabpot, sure I'll be happy to do it. But I took...

[Mailer] add reject to `MessageEvent` to stop sending mail

@VincentLanglet I'm going to take over.

[Mailer] add reject to `MessageEvent` to stop sending mail

> Should rejecting the mail stop the propagation of the `MessageEvent`? Currently, it doesn't and I thought we should at least have talked about it. That's a good question. My...

[Mailer] add reject to `MessageEvent` to stop sending mail

I would not trigger a `FailedMessageEvent` as the message didn't fail, it was just rejected from being sent. As you don't necessarily know all listeners that can be registered in...

[Mailer] add reject to `MessageEvent` to stop sending mail

I would let the listener do the logging when it makes sense. I tend to avoid logging whenever possible.

[Mailer] add reject to `MessageEvent` to stop sending mail

Thank you @y4roc.

[WebProfilerBundle] Improve accessibility of tabs and some links

Thank you @javiereguiluz.