Fabien Potencier comments

Results 226 comments of


Fabien Potencier

[Mailer] Add advanced logger

https://github.com/symfony/symfony/pull/47080 adds a new FailureMessageEvent that you can listen to, making logging a bit easier. I would not add this in core as the debug output can be very verbose.

Do not accept @ in email address local part unquoted

It's been done by @derrabus as part of supporting version 3 of the email validation lib: https://github.com/symfony/symfony/pull/39685/files#diff-f0d9919249d4352374874b02faa5eba0be74d75a2aee76b37b820e1453bfb3b7R55

Do not accept @ in email address local part unquoted

The linked PR also has some discussion about email validation.

[Mailer] Sending Messages Async with json serializer does not work

IIUC, there is no issue to fix in Symfony Mailer, but it's more about the inability to serialize an email to JSON via the Symfony serializer.

Symfony messenger with JSON serializer and AMQP transport (via RabbitMQ) failed to retry messages

Looks like a duplicate of #33394

Symfony\Bridge\Twig\Mime\TemplatedEmail should allow TemplateWrapper as html and text template

Seems reasonable to me. @sven-communitales Would you like to work on a PR? The main work will be maintaining BC.

[Mailer] TLS wrongfully enabled

This is the expected behavior. when using `smtp`, TLS is determined based on the port.

[WebProfiler] Add a limit how many profiles should be saved

I think it should be part of `FileProfilerStorage` (I would not add an interface for that for now as we don't want to support more than one storage anyway). Instead...

[Mailer] Added scheduling to API transport

We tend to not add features that are only available on one provider only. Could you have a look at some other providers to see if they also support this?...

[HttpKernel] Adding _renderer attribute like _format in request to make Fragment (SubRequest) detectable.

Can you explain how you're going to use this feature?