Zekun Wang comments

Results 12 comments of


                                            Zekun Wang

[Bug][move-compiler-v2] Disassembler output combines address and module name in call

At start there is a https://github.com/aptos-labs/aptos-core/blob/851f9ee81b9b2dcc6be69d1a8a81a005f9415b0b/third_party/move/move-compiler-v2/tests/file-format-generator/vector.exp#L5

[Compiler-V2] Add locations of arguments for stackless bytecode

All comments addressed. PTAL @vineethk @brmataptos

[Compiler V2] Control flow graph simplification

@vineethk The documentation is wrong. It should be Removes edges where the source has only one successor and the target has only one predecessor ``` BB1: xx goto L2 //...

[Compiler V2] Control flow graph simplification

> Can we add a small test case or 2 showing critical edges and what happens with them? Some of the break/continue loop tests probably should show critical edges. The...

[Compiler V2] Control flow graph simplification

I set the PR to draft temporarily since I'm adding more documentation, which facilitates code review.

[Compiler V2] Control flow graph simplification

All comments addressed. PTAL @vineethk @brmataptos

[Compiler V2] Control flow graph simplification

@brmataptos @wrwg @vineethk The PR has been refactored and ready for review now.

[Compiler V2] Control flow graph simplification

All comments addressed. PTAL @brmataptos @rahxephon89

[Compiler V2] Control flow graph simplification

Thanks for the comments. All addressed. PTAL! @vineethk

[Compiler V2] Control flow graph simplification

@vineethk All comments addressed. PTAL