aptos-core [Compiler-V2] Add locations of arguments for stackless bytecode

Description

This PR adds location information of the target and source registers for each stackless bytecode. We track this in the compiler V2 bytecode generator when constructing stackless bytecode from model ASTs, and record them in fields of FunctionData

pub struct FunctionData {
    ...
    /// Maps the attribute id of a bytecode to the ids of the source temporaries.
    pub target_locations: BTreeMap<AttrId, Vec<AttrId>>,
    /// Maps the attribute id of a bytecode to the ids of the source temporaries.
    pub src_locations: BTreeMap<AttrId, Vec<AttrId>>,
    ...
}

As an example use case, we use this to improve the locations in error messages from ability checking.

ability-check/assign.exp

 Diagnostics:
 error: local `s` of type `assign::S` does not have the `drop` ability
-   ┌─ tests/ability-check/assign.move:17:9
+   ┌─ tests/ability-check/assign.move:17:10
    │
 17 │         *s = S { f: 42, g: T { h: 42 } };
-   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ reference content dropped here
+   │          ^ reference content dropped here

ability-check/explicit_move.exp

 Diagnostics:
 error: local `x` of type `m::R` does not have the `copy` ability
-   ┌─ tests/ability-check/explicit_move.move:12:9
+   ┌─ tests/ability-check/explicit_move.move:12:14
    │
 12 │         some(x);
-   │         ^^^^^^^ copy needed here because value is still in use
+   │              ^ copy needed here because value is still in use
 13 │         some(x);
    │         ------- used here

TODO: When constructing bytecode with new attribute ids in later transformations, we also need to track the locations of its arguments.

Fixes #12974

Type of Change

[x] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Performance improvement
[ ] Refactoring
[ ] Dependency update
[ ] Documentation update
[ ] Tests

Which Components or Systems Does This Change Impact?

[ ] Validator Node
[ ] Full Node (API, Indexer, etc.)
[x] Move/Aptos Virtual Machine
[ ] Aptos Framework
[ ] Aptos CLI/SDK
[ ] Developer Infrastructure
[ ] Other (specify)

Apr 25 '24 05:04 fEst1ck

⏱️ 5h 2m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-targeted-unit-tests	1h 28m	⬜ ⬜ 🟩 🟩 🟩 (+1 more)
rust-move-unit-coverage	1h 21m	🟩 ⬜ 🟩 🟩 🟩 (+1 more)
rust-move-tests	52m	🟥 ⬜ 🟥 🟩 🟩 (+1 more)
rust-lints	28m	🟩 ⬜ 🟩 🟩 🟥 (+1 more)
run-tests-main-branch	25m	🟩 🟩 🟩 🟩 🟩 (+1 more)
general-lints	11m	🟩 🟩 🟩 🟩 🟩 (+1 more)
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+2 more)
semgrep/ci	3m	🟩 🟩 🟩 🟩 🟩 (+2 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
file_change_determinator	1m	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+1 more)
permission-check	23s	🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check	22s	🟩 🟩 🟩 🟩 🟩 (+2 more)
permission-check	20s	🟩 🟩 🟩 🟩 🟩 (+1 more)

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

Apr 25 '24 05:04 trunk-io[bot]

Maybe you forgot to push some updated code?

Apr 30 '24 03:04 brmataptos

All comments addressed. PTAL @vineethk @brmataptos

May 02 '24 01:05 fEst1ck