Fabrizio Ferrai

Results 440 comments of Fabrizio Ferrai

Yes, this is an optimisation that we should implement. Right now we do the naive (but correct) thing of just cloning the repo for each of the packages - we...

Do we have any tests for this flag? If not, we should add one

The emojis are not for cuteness, but for clarity of display - I put them there to grab attention in key parts of the build, e.g. see here, they appear...

Ah indeed that doesn't look good. The only emojis that we use are ❌ and ✅ and ⚠️, we can switch them out for equivalent Unicode symbols if we can...

Cool, we can go for `✔`, `⚠` and `✖`, and skip them if we are running with `no-color` (since TTY won't support that either)

Thanks for the detailed report @Blugatroff! We had a similar report in #1140, but that's unfortunately very light on details which made it hard to investigate. Indeed 3.5s is a...

@Blugatroff I had a look at your `pure-advent` repo, and I can't repro the slow globbing - it takes about __30ms__ to read the globs, __250ms__ to read the lockfile,...

I have merged the PR linked above, and parsing times have improved for Spago itself as well - it now takes 150ms to glob the workspace (vs 400ms before the...