Eugene Yurtsev

Out of date. closing

@tjaffri thanks for submitting the PR! I'll review on Monday (maybe before if I find enough time). Apologies for the delay!

Merged on separate branch

It's a breaking change, so if we're OK proceeding, let's relabel commit title to `Breaking Change` so we remember to include it in the release notes as such. Will need...

I'm in favor of having a generic provenance field that captures the protocol / storage. As long as the provenance field is completely specified it makes it easy to treat...

@hwchase17 this looks reasonable to me. I haven't worked as much with the vector stores, so maybe another set of :eye: will be helpful. Also left a challenge for @EandrewJones...

@hwchase17 @dev2049 Two questions to figure out here: 1) We don't have benchmarks anywhere. Adding another parameter makes the task more complex which means that performance will likely decrease. It...

Thanks you @lesterpjy !! I'll try to review in the evening. I'm in the process of the loader abstraction to decouple parsing from loading of content to make it easier...

Hi @rick2047 thank you for the contribution! :wave: I'm not super familiar with Makefile syntax. I patched the PR in and haven't been able to run tests selectively ``` langchain...

@rick2047 are you able to make the path to not be specified relative to test/unit_tests/ so that a user could use the shell to auto-complete paths with tab complete?