Eugene Yurtsev

Results 464 comments of Eugene Yurtsev

@lesterpjy I'm updating some of the files that you're also working on, which will be causing annoying merge conflicts for you. If you I can commandeer your PR from here...

@aditya-pethe I outlined some changes to the poetry file. The goal is to treat all these dependencies as optional, so the module code should not assume that the dependency is...

> add a test, possibly in tests/integration_tests/utilities/test_powerbi_api.py, which attempts to import azure.core.credentials You can place the test under `tests/unit_tests/` path instead of `tests/integration_tests`. This will get CI to pick up...

Hi @aditya-pethe it looks great. We still need to make one change to the unit test so the test verifies that the code can be imported with azure dependency missing....

https://github.com/hwchase17/langchain/pull/4983

was merged https://github.com/hwchase17/langchain/pull/4983

Hi @DominickDiaz could you rename the file to add a .py suffix? it's not recognized as a python file right now.

@bongsang Thank you for helping improve the documents! I have one comment about the notebook, let me know if you have any thoughts / objections.

This looks good to me, but there's a confict