Eugene Yurtsev

Results 468 comments of Eugene Yurtsev

> @eyurtsev Hey Eugene, I've made it as a "not breaking change" :) Introduced an optional `query` parameter in BaseLoader. In this way, we don't need to add it to...

@blob42 regarding tqdm question, you can add tests the unit test folder. and use the @pytest.mark.requires('tqdm') decorator. It'll skip the test when running core tests, but pick up the test...

Have to run right not, will try to finish later today or tomorrow! Thanks for the benchmarking!

@lyz1990 change looks good -- thanks for helping out!! Would you be able to resolve the linting issue and then we can merge?

@MikeMcGarry Thank you for the PR. This is a major improvement to how ever note document loader works! @hwchase17 thoughts on backwards compatibility?

Thank you! as a heads up, will commandeer tomorrow to help resolve merge conflicts around poetry.lock files, there's a bunch of PRs that are bumping into merge conflicts, so will...

Code looks ready for merging. Waiting for tests to pass and then can merge in. Thank you @MikeMcGarry

@richarddwang thanks for the contribution! Would you mind only keeping the encoding changes for loaders that deal with a single file?

Hello @marcusyatim contribution much appreciated! I added some high level comments. I would love to standardize metadata handling across the various loaders! I added some comments, I think there are...

@lesterpjy Thanks looking great! a few minor comments and then we can merge! Thanks for putting the time to work on this!