Philip Theus (prev. Mueller)
Philip Theus (prev. Mueller)
### Pre-submit checks - [X] I checked for similar issues beforehand, but could not find any. I could not add my proposal to any existing issue. - [X] I am...
Ruby codebases often use `JSON.generate` and `.to_json` interchangeably. The `Style/ToJson` cop helps unify to `to_json` to reduce confusion, and includes a safe (I hope) autocorrect. ```ruby # bad JSON.generate(something) #...
Fix https://github.com/rubocop/rubocop-rails/issues/1179 Before submitting the PR make sure the following are checked: * [X] The PR relates to *only* one subject with a clear title and description in grammatically correct,...
## Expected behavior These are the examples from the docs: ```ruby # bad has_many :accounts, class_name: Account has_many :accounts, class_name: Account.name # good has_many :accounts, class_name: 'Account' ``` I would...
Currently, ```html Some Headline ``` is converted into ```markdown ### Some Headline ``` in atx style, which is not valid markdown.
It seems that in version 4.1.1, `JSON::Validator#validation_errors` always returns `[]`. I think it's due to the `@errors` attribute being reset during validation: https://github.com/voxpupuli/json-schema/blob/76ea712a7fb444b738abbdc35295a6ccbd8d69e4/lib/json-schema/validator.rb#L126 . To reproduce: ```ruby schema = {...
We've been using this library for years, but only recently started adopting `call!` for fast failures. We found that the behavior of a nested `call!` vs a `fail!` was surprising....
trying to run `pks` on the app I'm working on right now, it complains about path collisions between `packs/*/app/models/something.rb` and `packs/*/app/admin/something.rb`. But `app/admin` isn't actually autoloaded. This is apparently the...