shifterator icon indicating copy to clipboard operation
shifterator copied to clipboard

python 3.10 compat

Open exterm opened this issue 1 year ago • 5 comments

exterm avatar Mar 09 '23 22:03 exterm

For backwards compatibility, would recommend changing the import to something like this, rather than accessing the module on line 156.

try:
    from collections.abc import Mapping
except ImportError:
    from collections import Mapping

mvarnold avatar Aug 14 '23 20:08 mvarnold

Fixed.

exterm avatar Nov 04 '23 18:11 exterm

@mvarnold

exterm avatar Feb 26 '24 17:02 exterm

@ryanjgallagher

exterm avatar Jun 24 '24 15:06 exterm

Looks good to me (thanks!!) and looks like I could merge this but a few thoughts:

  1. We don't have any github action running to confirm that the code changes work (I suppose I could just try locally)
  2. More importantly, probably, I don't have access to the pypi deploy (and this is also not automated) so just merging it wouldn't help. We need Ryan to deploy the change.

I'd recommend Ryan set up both of those just to make these changes more push-button in the future.

@exterm I sent a message to Ryan on our old Slack, I'll try to get it updated if I can.

andyreagan avatar Jul 02 '24 15:07 andyreagan