Results 14 comments of ewallah

with every call to src\transformer\get_event_function_map() ``` core\event\content_viewed has been deprecated. core\event\course_module_instances_list_viewed has been deprecated. core\event\message_contact_blocked has been deprecated. core\event\message_contact_unblocked has been deperecated. core\event\role_capabilities_updated has been deprecated. mod_lesson\event\highscore_added has been deprecated....

You are only checking the langx tags, and the errors are related to these xx tags. When other elements are checked, most filtering is working fine: ``` public function test_other_filtercodes()...

Some tests are not working because there are missing slashes: ``` 'before' => '{langx es}Todo el texto está en español{langx}', 'after' => 'Todo el texto está en español', ``` should...

Now I have a working php phpunit file in https://github.com/ewallah/moodle-filter_filtercodes/blob/master/tests/filter_test.php But the script also shows the weaknesses: - there are no try..catch statements in the functions that use get_string (What...

phpdoc also needs a cli installation of Moodle. But if you are in a hurry and can live without phpunit - behat - grunt - phpdoc, one can already have...

Perhaps the sample scripts could be updated so the latest version is always used: ``` - composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4 + composer create-project -n --no-dev --prefer-dist...

Just mentioning that PHP 7.4 is [end of life](https://www.php.net/eol.php). Support stopped on November 28th, 2022.

Since December 2022, the [coveralls-upload](https://github.com/ewallah/moodle-enrol_coursecompleted/actions/runs/3964428520/jobs/6793279402#step:18:1) stopped working with an Invalid handle provided: ``` Collect git info Read environment variables Dump submitting json file: /home/runner/work/moodle-enrol_coursecompleted/moodle-enrol_coursecompleted/moodle/enrol/coursecompleted/build/logs/coveralls-upload.json File size: 50.85 kB Submitting to...

Proof of concept submitted in https://github.com/ewallah/moodle-plugin-ci Works in 3.7 - 3.8 - master: https://travis-ci.org/ewallah/moodle-plugin-ci/jobs/650857771#L455 Fails in 3.6 - 3.5 - 3.4 - https://travis-ci.org/ewallah/moodle-plugin-ci/jobs/650857773#L497 due to "Too many open files" Someone...