facebook ink
facebook ink
# Expected Result - URL's added for Audio, Image, Slideshow, Iframes etc should be validated Links can: - have the protocol notation: //domain.com/path/image.png - Use base64 - Use relative link...
# Refactory Decouple the Warnings and Logs reference from Transformer instance and set it as a reference for a class that will hold the Warnings and the Logs (Logger)
We should consider using XHP for the [hhvm](https://github.com/facebook/facebook-instant-articles-sdk-php/tree/hhvm) branch
Remove the necessity of using the "type" on each property for the rules on the transformer.
Reference: https://github.com/facebook/facebook-instant-articles-sdk-php/pull/280/files/4a9295d3e17006a7496c344ad80c8a85b0d426e1#discussion_r151804844
We need to treat correctly the charset encoding and also force parameter \DOMDocument to be created already or we create it considering the charset encoding informed Also make parameter required....
Currently, loadHTML (DOMDocument) does not do anything on parsing cdata and the script content can include CDATA tags. This causes an issue on Elements\GeoTag->isValid() and the code omit script in...
This is an enhancement. Right now we have messages all centered into [validator_warning_messages.ini](https://github.com/facebook/facebook-instant-articles-sdk-php/blob/master/src/Facebook/InstantArticles/Transformer/Warnings/validator_warning_messages.ini) This should be separated and every single validation should do its messaging.
# Expected Result All elements that uses GeoJSON should be validated if it is: - Valid JSON - Valid GeoJSON # Actual Result - It validates only if not empty....
This PR: * [x] Adds PassThroughRule for tag `` Fixes #615