fb-instant-articles icon indicating copy to clipboard operation
fb-instant-articles copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Adds a default PassThroughRule for tag `<sup>`

Open everton-rosario opened this issue 7 years ago • 6 comments

This PR:

  • [x] Adds PassThroughRule for tag <sup>

Fixes #615

everton-rosario avatar Mar 06 '17 17:03 everton-rosario

@everton-rosario What work is left here to get this merged?

timjacobi avatar Oct 02 '17 13:10 timjacobi

Actually I'm not sure if I agree with this PR. I feel like we should rather define a new rule that converts a character wrapped in a <sub> tag to its superscript equivalent. Otherwise the widely used m² would be converted to m2 for example. I think that would make people unhappy.

timjacobi avatar Oct 11 '17 15:10 timjacobi

@timjacobi can you propose a patch that does what you want?

paulschreiber avatar Jan 09 '19 17:01 paulschreiber

Someone at facebook, please point out to someone that can change things how absurd it is that these simple HTML tags don't work in IA.

It's sad that we have to consider these options.

jerclarke avatar Jan 09 '19 21:01 jerclarke

Somehow this got lost in between releases.

I'll update the PR with the proper tags added.

everton-rosario avatar Jan 09 '19 21:01 everton-rosario

We do render it not so gracefully into the UI of Instant Articles, though we do support the <sub>/<sup> tags.

I'll possibly change this PR to properly have the tags and the proper rules, so we don't need to bypass them, rendering it properly as sup and sub tags.

everton-rosario avatar Jan 09 '19 21:01 everton-rosario