志宇 comments

Results 288 comments of


                                            志宇

chore: extract `TestEnv` into separate crate

Also could you please add a simple README for `bdk_testenv`? Thanks!

Add wallet sync_request and full_scan_request functions

@notmandatory do you mind adding a more detailed explanation as to how this pushes us in a direction to have a higher-level method/methods for syncing a wallet?

Option for Electrum and Esplora APIs to include floating `TxOut`s in updates for fee calculation

That's a good point @LLFourn. Should be straightforward for Esplora then.

`reveal_next_spk` should have a way of reversing the change

How about a callback method? ```rust pub fn reveal_next_spk_on_persist(&mut self, keychain: &K, persist: C) -> Result where C: FnMut(super::ChangeSet) -> Result { todo!() } ```

Calling `example_electrum sync` on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli))

New discovery: The cli saw it as confirmed after I called `scan` after one additional confirmation.

Calling `example_electrum sync` on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli))

May be fixed by this: https://github.com/bitcoindevkit/bdk/issues/1354

Add list of reference projects using BDK

https://bitmask.app/ https://github.com/RGB-Tools/iris-wallet-android

Backwards compatibility of `bdk::ChangeSet` data structure

@tnull so you want an older version of BDK to understand changesets that a newer version of BDK outputs. Can you elaborate why this would be useful? Thank you

Backwards compatibility of `bdk::ChangeSet` data structure

I suggest we go ahead with this and do what is described in the ticket description.

Retry failed RPC calls on error

Closing this for now as this deals with legacy code.