志宇
志宇
Right now the RPC emitter must emit blocks contiguously (cannot skip blocks), because we are emitting `(u32, Block)` and we construct the chain update from the block header. If the...
> I did suggest this but fwiw I am not entirely convinced it's a good idea. @LLFourn can you please expand on why it's not a good idea? Thanks
I have re-purposed this ticket to track the `bdk_nakamoto` crate implementation.
@notmandatory if we wish to make the `lookahead` configurable in `bdk::Wallet` for alpha.3, I think it will be a good idea to include this in the release. Otherwise, I am...
It makes sense to complete this AFTER #1203 is merged (as that PR also touches wallet constructors).
The commit message does not need `()`.
@vladimirfomene that's a great point. https://github.com/bitcoindevkit/bdk/blob/release/0.29/src/testutils/blockchain_tests.rs Maybe the old `testutils` is something to base this work on.
In terms of commit-hygiene, I think this PR should be at least two commits. One for extracting the `TestEnv`, one for introducing the `electrum` tests.
I think you will need to do a really annoying rebase :/ sorry about that!
I think git is being weird, can you re-rebase on master? Make sure your remote is up to date!