志宇

Results 288 comments of 志宇

@kjain1810 Are you still planning to continue with this? If so, I personally think it is better to base changes on the current implementation of rpc blockchain (it has basically...

> eak concept NACK. > > If my understanding is up to date we currently use `max_satisfaction_weight()` to figure out weight for coin selection which will not use the grinded...

@vladimirfomene I personally don't think it will hurt if you get started with changing how our Software "signers" are implemented first. However, since this is still tagged as discussion, I...

@danielabrozzoni I also think this is ready to be worked on. I think the changes on the signer-side is a "no-brainer" (for the reasons that you have mentioned). In terms...

This is exciting that `rust-hwi` is finally getting integrated into BDK :) I'm wondering whether "Hardware Wallet" is the best name since we have a struct named `Wallet`, and there...

@elsirion Thank you for your review! Just to make sure I understand you, this should be my next steps with this PR: * Make running `bitcoind` via rust the only...

> @evanlinjin So the advantage of using `bitcoind` is that it can be automatically downloaded and run from Rust, rather than to rely on it already running? Yes, this is...

I think this is rather important, as we don't want delays from other transports to cause an unneeded rule expiry.

@danielabrozzoni > Why? 1 WU = 0.25 sat/vbyte. If you can have 0.1 sat/vbyte, then you also need decimal weight units. Or am I misinterpreting what you're saying? (I haven't...

Although this PR will increase the "correctness" of our weight calculations, if there are bugs in miniscript `max_satisfaction_weight` we may end up undershooting, which is dangerous. I think this should...