志宇
志宇
Also, the anchor changes that I am suggesting is going to conflict with `ConfirmationBlockTime`.
@LagginTimes could you provide the benchmark results in the PR description and compare it to results before the changes in this PR?
@LagginTimes ~~can you provide the code you used to test with a remote electrum server (instead of the testenv)?~~ Edit: how about we just test with the example-cli with a...
@notmandatory I prefer we rebase this on top of bitcoindevkit/bdk#1514 since that PR is more "final" than this one.
As discussed privately, it makes sense to rm `TxGraph::anchors` field. ```rust pub struct TxGraph { // all transactions that the graph is aware of in format: `(tx_node, tx_anchors)` txs: HashMap,...
This is great work. However, we have concluded that we do not have enough time to get this into `v1.0.beta` (as discussed).
Thanks for writing this up. I have some further questions. Do you need the wallet to be able to sync up to a specific blockhash? Or is syncing up to...
You don't need `bdk_electrum` to reexport features. You can just add another dependency to `liana`'s `Cargo.toml` file. ```toml electrum-client = { version = "0.21.0", features = ["use-openssl", "proxy"] } ```
> To give a bit of context. This PR isn't meant to be the final API or the internal design for multi descriptor wallet. There are many potential improvements to...
I don't think this should be left open since the approach here is wrong and this PR is very outdated. bitcoindevkit/bdk#1539 is a more sane approach. Additionally, we have ticket...