志宇
志宇
Thanks for the initiative on this, better docs are always better.
@ValuedMammal I think that's fine for now, can add them later
This is what we've all been waiting for.
We need to test this against reorgs. It seems like the architecture of this may result in inconsistent state of checkpoints during reorgs. 1. Have a chain with blocks `.....
@LagginTimes is this ready to review again? Remember to mark it as so and request reviewers, otherwise no one will know about it.
What was the discussion around breaking changes? Were we okay to break the API?
Looking back through the codebase, I noticed that we've introduced a condition that wasn't there before, and I’m wondering about the best way to handle it. Since a `Header` contains...
I've started experimenting with my suggestion in https://github.com/bitcoindevkit/bdk/pull/1582#issuecomment-3214838670. This is the WIP commit: https://github.com/evanlinjin/bdk/commit/8f374ccb639e98836b482d3cb0e704ec64f50aa1. I'm quite happy with the implementation of it (unless proven otherwise). What is missing: * Figure...
@LagginTimes I'll be happy with that. Do we have a plan for back-porting the non-merged chain-source fixes (#2005, #2011, #2000)? Note that the `CheckPointEntry` PR may break the API again.
I think we should not wait for complete tests before merging this PR. As long as the examples work fine it is good. This is for "beta" which does not...