志宇

icon company @bitcoindevkit icon location Taipei icon location Building @bitcoindevkit Forging @frostsnap

Results 288 comments of 志宇

Introduce TLV for bdk_file_store

I agree with @LLFourn's suggestion. I think someone should take this ticket on.

PersistedWallet: allow `load_wallet()`, `create_wallet()`, and `persist()` to accept `Arc<P>`

@bennyhodl I'm assuming `P` is a trait object of `dyn Storage`? If so, would implementing `WalletPersister` for `Arc` work for you? However, it seems you intend the `Storage` trait to...

fix(electrum): `bdk_electrum` coinbase merkle and `populate_with_txids` exploit fixes

Thank you for working on this. However, I'm not sure how useful this is here, since we aren't even verifying the PoW of the chain in `bdk_electrum`. `bdk_electrum` assumes that...

test(chain): add several basic scenarios to test transaction conflicts

@pluveto could you please rebase on master to fix CI? We just merged the fix for CI.

Electrum client Performance issues

Thank you for this. Could you please be a little more specific so it's easier to identify the performance issues? I.e. are you doing full scan or sync? What parameters...

Electrum client Performance issues

Having a stop gap of 500 means you'll be scanning 500 extra addresses. Does reducing this improve the situation?

Implement generics for `CheckPoint`, `LocalChain`, and `spk_client` types

I'm rooting for this change. Being able to have `CheckPoint` means we can guarantee that we have a `Header` per checkpoint. Currently, [`bdk_electrum_c`](https://github.com/evanlinjin/experiments/tree/main/bdk_electrum_c) (the streaming Electrum BDK chain source I'm...

Appending changesets to `Store` after opening causes overwriting

Thanks for writing up this ticket. The intended usecase of `bdk_file_store` is with BDK structures. With BDK, we never read after writing. Maybe we can structure things to be more...

Add comprehensive fee estimation documentation and examples for all supported backends

Closing as https://github.com/bitcoindevkit/bdk/pull/1959#issuecomment-2894582995 is now the agreed-upon approach.

(Needs Help): Add documentation for Electrum's full_scan/sync

1. For all the chain sources right now, the confirmation time is the block header's timestamp. I think this should always be the defacto-definition (so, yes). 2. Fee here is...