Evgeni Burovski

Results 624 comments of Evgeni Burovski

Updated to address review comments, add some array-like tests, improve a link to a CuPy fix to investigate after a CuPy makes a 14.0 release, and added enough skips for...

Yes, thanks for the ping. My plan is to look at this and gh-321 right after 1.12 is out of the door (so that pytorch==2.7 is usable).

Sorry for the delay. This PR seems to have some visible effects on which names are available from the wrapped namespaces. Are these intended? ``` On main ------- In [13]:...

Okay, thanks. So, if I read this right, as compared to main this PR - adds some symbols (`Final` for dask.array) - hides some symbols present in the bare namespace...

Great, thanks. I misread then. What still exists is hiding private symbols (see below for torch). Would it be difficult to remove the filter and pass through whatever the library...

One problem is it is a regression. On main (unless I'm being dense again): ``` In [3]: set(dir(xp)) - set(dir(torch)) Out[3]: {'UniqueAllResult', 'UniqueCountsResult', 'UniqueInverseResult', '__array_api_version__', '__array_namespace_info__', '_aliases', '_info', '_typing', 'astype',...

Okay, lets merge this and see about exporting private items separately (Checked it: they have been hidden from at least 1.9.1; thus it's rather low prio; let's wait for if...

This indeed looks like a collection of `array-api-compat` issues, which stem of this sort of constructions: ``` def trunc(x: Array, /, xp: Namespace, **kwargs: object) -> Array: if xp.issubdtype(x.dtype, xp.integer):...

https://github.com/data-apis/array-api-compat/pull/333 loops over unary functions and fixes `trunc`, `ceil` and `floor`. Potentially there are more potentially trickier cases, but those are not tested for in gh-333 just yet.

To clarify my position on the matter: Since the spec does not mandate whether any given function returns a view or a copy, this is "unspecified, thus implementation-defined". This is...