Evgeni Burovski

Results 624 comments of Evgeni Burovski

Thanks @mtsokol ! This is a great idea. A couple of quick comments: - hypothesis does indeed sometimes make figuring out the inputs quite hard! - the current `ph.assert_*` helpers...

> I can take a look at the tests that I've fixed in the past and provide a few more next week! Thanks! I'd be very helpful. > In array-api-tests...

You mean add a note to this effect to the "Interpreting errors" section of the README? https://github.com/data-apis/array-api-tests/blob/master/README.md As a usability check: would this be useful to you when you had...

As long as it's a couple of `hasattr` checks, it's not a problem (any `hypothesis` work dwarfs that, by far). Basically, what you talk about is https://github.com/data-apis/array-api-tests/issues/51 --- and if...

Here's a low-tech POC to emit exact reproducing snippets for failed tests: https://github.com/data-apis/array-api-tests/pull/384 (the bulk of the diff is a trivial indentation change, so it is best viewed with the...

https://github.com/data-apis/array-api-compat/pull/253 seems to have run into a wall with uint promotions in pytorch, did something change meanwhile in the meantime?

> this PR changes neither CI nor __array_namespace_info__, which is what makes that PR non-mergeable. You lost me here :-). So is it basically "let's add something because we want...

> We can either keep this PR unmerged, or leave it in main but untested by CI. The latter we definitely do not want to do.

cc @lucyleeow who has been recently working on multiple device support for scikit-learn

Could you remove the skipped tests @mcdigman? Then we'll be able to quickly merge this PR, and proceed with the plan of https://github.com/scipy/scipy/pull/22888#issuecomment-2887174675