Evgeni Burovski

Results 624 comments of Evgeni Burovski

Actually, ``` $ export ARRAY_API_TESTS_SKIP_DTYPES=uint16,uint32,uint6 $ export ARRAY_API_TESTS_MODULE="exec('from array_api_compat import torch as xp; import torch; torch.set_default_dtype(torch.float64)')" $ pytest array_api_tests -v --max-examples=1_000 -v --xfails-file ../array-api-compat/torch-xfails.txt --skips-file ../array-api-compat/torch-skips.txt ``` does not bring...

Thanks Jake! So for completeness, the stanza to locally run a test from the test suite is ``` $ JAX_ENABLE_X64=true ARRAY_API_TESTS_VERSION="2024.12" ARRAY_API_TESTS_MODULE=jax.numpy pytest path/to/test ``` (EDITED to account for the...

This is a great start! I think it's best to generalize it from the onset to address https://github.com/data-apis/array-api-tests/issues/51 Ideally, there's a decorator (or a specific pytest mark, whichever is easier)...

This seems to be conceptually wrong. Now, what do we actually want to be testing here: - a pedantic implementation of the spec? then we only need to run `array-api-strict`,...

> How can we see that torch passes the test with this change Locally one incantation is (run from the source tree of the `array_api_tests` clone): ``` ARRAY_API_TESTS_SKIP_DTYPES=uint16,uint32,uint64 ARRAY_API_TESTS_MODULE=array_api_compat.torch pytest...

Now that https://github.com/pytorch/pytorch/issues/146211 is fixed in pytorch, we'll be able to undo the workaround of this PR for `take_along_axis`--- when the minimum supported torch version includes the fix. What is...

https://github.com/data-apis/array-api-tests/pull/397#issuecomment-3602935540 : tests aiming to probe this pass locally, let's see if CI agrees. EDIT: and it does. Merging.

I'd consider deprecating comb, actually. The functionality is available via math.comb or special.binom.

cc/fyi @mdhaber : IIRC scipy.stats is a big user of the `[()]` empty tuple indexing. Apparently, it is problematic for torch.vmap, especially if used on the left of the =...

> here's still the too many public symbols issue: Try adding `link args: version_link_args` to meson build. Seemed to do the trick in a recent PR: https://github.com/scipy/scipy/pull/21551/commits/63569e0d2acb751ef396137a29ba67400ef8b1f0