Evgeni Burovski
Evgeni Burovski
Okay, https://github.com/scipy/scipy/pull/21984.
`angle` is a thin wrapper on top of `atan2`. Here's the numpy implementation: https://github.com/numpy/numpy/blob/v2.1.0/numpy/lib/_function_base_impl.py#L1670-L1724 So it's literally `atan2(xp.real(z), xp.imag(z))` for complex-valued `z` plus some additional gymnastics due to `xp.imag(real.input)` refusing...
Ah, indeed. gh-801 looks more polished of course. Can't see what the rendered docs look like since the link has expired and CircleCI needs a kick from somebody with the...
OK, reverted all changes to `spec/`, so that only files in `src/array_api_stubs/_draft/*` are affected.
Have bumped the milestone. Might be great to actually write a test. Maybe we should even transfer this issue to `xsf`, where the dual math now lives.
> Maybe gh-20337? No way it can explain the runtime change from 15min to 4 hrs. Something else must have changed. I'd first verify the "new" run time is stable,...
1. Do you see it on other platforms, or can you confirm it's windows specific? 2. Can you reproduce this locally?
Just to confirm: with scipy 1.13 the Windows CI run takes 4hrs and MacOS and Linux runs take 15 mins, correct? Also, with scipy 1.12, all of them are 15...
> NumPy scalars duck type with float, which is fine ... all we need is a doc update in the standard that says "duck typing is allowed" Not sure how...
PR most welcome!