array-api-tests icon indicating copy to clipboard operation
array-api-tests copied to clipboard
verified publisher icon data-apis

missing extensions are not ignored by default

Open lucascolley opened this issue 1 year ago • 3 comments

https://github.com/data-apis/array-api-tests/blob/606cc4d11fbcb9abdf425ea6bfe21405228d1d89/README.md?plain=1#L174-L179

seems false. See https://github.com/mdhaber/marray/actions/runs/12521857195/job/34929420471?pr=47, which runs pytest -v -rxXfE --ci --max-examples=100 --derandomize --disable-deadline array_api_tests/

lucascolley avatar Dec 27 '24 23:12 lucascolley

perhaps

https://github.com/data-apis/array-api-tests/blob/606cc4d11fbcb9abdf425ea6bfe21405228d1d89/array_api_tests/test_has_names.py#L26-L28

should be using enabled_extensions from here

https://github.com/data-apis/array-api-tests/blob/606cc4d11fbcb9abdf425ea6bfe21405228d1d89/conftest.py#L20-L23

lucascolley avatar Dec 28 '24 00:12 lucascolley

it seems that test_has_names doesn't take --disable-extension into account when it is set either.

lucascolley avatar Dec 28 '24 00:12 lucascolley

PR most welcome!

ev-br avatar Jan 01 '25 18:01 ev-br