Evgeni Burovski
Evgeni Burovski
Just a note in passing: there are both kinds of mpmath usages in scipy tests, both calling mpmath routines in a test itself, and using mpmath to generate reference values....
Will do, thanks. ETA is "not today or tomorrow" though.
I don't think I've anything useful to say here, sorry.
The refguide-check you're removing now was still doing something: - checking that the routine listing in `__init__.py` files agree with `__all__` lists (the original refguide checking) - doing some ReST...
> Is there an option in scipy-doctest to do RST block doctests? `spin check-tutorials` check _doctests_ in rst files under `numpy/doc/source/user` if that's what you mean. But rst syntax, no,...
> Is there some ReST validation the old code does that is removed in this change? Yes. https://github.com/numpy/numpy/blob/main/tools/refguide_check.py#L392 _I think_ (not 100% sure) this basically whitelists ReST directives. Whether it's...
TL;DR I think it's best to keep the current state with three separate calls on CI, `check-docs`, `check-tutorials` and `refguide-check`. Indeed, scipy-doctest is not a complete replacement for refguide-check. refguide-check...
> rather than remove refguide_check, I will trim it to only do the two missing tests, and not the complete doctesting that is done in scipy-doctest. Agreed! This, I believe,...
Am wondering if - is this useful as a general-purpose root-finder? - are you planning to make this routine public at some point? - can one make definite statements comparing...
What is result and is type(result)?