Eugene Manuilov

Results 169 comments of Eugene Manuilov

@tofumatt, I have a question for you: https://github.com/google/site-kit-wp/pull/5660#discussion_r943489714, do you mind looking at it?

> * Create a new variable named `isGA4Setup` which uses the `useSelect` hook to run the `getPropertyID()` selector from the `modules/analytics-4` store (`MODULES_ANALYTICS_4` constant). Use the double exclamation operator (`!!`)...

> * In both `assets/js/modules/analytics/components/setup/SetupFormGA4.js` and `assets/js/modules/analytics/components/setup/SetupFormGA4Transitional.js`: @nfmohit the `SetupFormGA4` form will appear only when there are only GA4 properties for the selected account and no UA properties at all....

> A proof-of-concept PR has been added with most of the implementation mentioned below [here](https://github.com/google/site-kit-wp/pull/5667). This can be used as a starting point, ensuring these next steps: @nfmohit, please, avoid...

> If we adjust components to not output Analytics component when the module is not available everything should work fine. Here's a list of places we're checking for a false-y...