Eugene Manuilov

Results 179 comments of Eugene Manuilov
trafficstars

> That brings another question, what do we do with the Setup incomplete: continue module setup(http://sitekit.10uplabs.com/wp-admin/admin.php?page=googlesitekit-dashboard&slug=adsense&reAuth=true) link? @hussain-t we should do nothing with that link, it should remain as is....

@tofumatt @techanvil how do we suppose to deal with duplicates? Let say we have `Get Help` and `Get help` strings, then we can use `Get help` text and `text-transform: capitalize`...

> In `assets/js/modules/thank-with-google/components/dashboard/ActivationBanner/SetupBanner.js`: @techanvil I believe this file should belong to the `analytics-4` module, shouldn't it?

> * Remove the use of `await registry.__experimentalResolveSelect( CORE_MODULES ).getModules()` within the codebase. @asvinb, we can't just remove it from the codebase because it will cause failure. What we need...

> ... basically we no longer need to call `await registry.__experimentalResolveSelect( CORE_MODULES ).getModules()` before calling `getModule`, `isModuleActive` or `isModuleConnected`... @asvinb, yes, we don't need to call `getModules` anymore, but we...

@felixarntz or @aaemnnosttv could you, please, help to define AC? Not sure which approach is the right for this, seems like the `sprintf` one is the best, what do you...