site-kit-wp icon indicating copy to clipboard operation
site-kit-wp copied to clipboard

Extract Google product names from translatable strings for consistency

Open eugene-manuilov opened this issue 3 years ago • 1 comments
trafficstars

Feature Description

Currently, we don't have strict rules regarding product names in translatable strings thus our translations contain product names which may be translated by the community. This become more important with the launch of the Thank with Google integration. People that aren't familiar with the Thank with Google product may not understand what this mean and translate it into their local languages.

We need to update our translation strings to exclude product names from it and use placeholders instead that will be replaced with actual product names in the runtime.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

eugene-manuilov avatar Jul 27 '22 15:07 eugene-manuilov

@felixarntz or @aaemnnosttv could you, please, help to define AC? Not sure which approach is the right for this, seems like the sprintf one is the best, what do you think?

eugene-manuilov avatar Jul 27 '22 15:07 eugene-manuilov

This can be closed as #7650 is more/less this issue, and has more discussion/context.

tofumatt avatar Nov 21 '23 15:11 tofumatt