Bob Ippolito
Bob Ippolito
I would really like to see this included before the next release, it fixes all of the noise in the tests (and in `__DEV__`). It's annoying to work on the...
All tests are currently passing, the failure is the label-on-approval workflow issue being debugged in #6153
Pretty sure that this was fixed
This looks like it solves the same problem as #6076 so it should close that as well if this PR is chosen. My review comments would be basically the same:...
I think this approach is probably better, but without really any docs or test coverage it's hard to say if there are any additional caveats to this simpler solution
Good idea, it seems that there is a lack of test coverage all around for this corner of the API!
I think a better fix is to move the icons folder from public to src, then the relative paths in the css will work and vite will bundle them (mostly...
If you `mv public/icons src/icons` it just works as-is, without changing any code
Unfortunately I can't merge this until the request for changes review is dismissed, if you'd like to submit this fix as a new PR please do so.
Sorry, I am not familiar with all of the changes that have occurred in these packages and their dependencies. It looks like it expects typedoc to have this method https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/src/index.ts#L91