Bob Ippolito

Results 251 comments of Bob Ippolito
trafficstars

Test failure looks like a flaky collab run

I am not seeing any significant difference in size. | Module | v0.14.5 | v0.15.0 | #6048 | #6048/v0.14.5 | |-|-|-|-|-| | Lexical.js | 22.27 kB | 22.44 kB |...

@Sahejkm I have a feeling that something is being measured in www that is not being measured in OSS and I just do not have enough information to reproduce whatever...

I added a commit to #6048 that I believe resolves this regression, but size-limit doesn't see anything that happens to the react modules. #6048 after fix: ``` $ npm run...

This shouldn't be merged until after #6080 as I will need to revisit the workflow additions

@StyleT ready to go, you will need to add the `extended-tests` label if you want the full e2e suite to run

The test failure looks like a github fault https://github.com/facebook/lexical/actions/runs/9106181327/job/25032956714?pr=6048 ``` Download action repository 'actions/checkout@v4' (SHA:0ad4b8fadaa221de15dcec353f45205ec38ea70b) Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/0ad4b8fadaa221de15dcec353f45205ec38ea70b'. Error: nodename nor servname provided, or not known (api.github.com:443)...

Closing and re-opening to kick off another test run

Doesn't look like that fired off another extended test run

Hard to tell which test hung but I'll take a look, I suspect restarting the test suite would pass though because they passed before.